Skip to content

ci(bigtable): split admin and data IT profiles and add parallel presubmit configs - #15060

Open
igorbernstein2 wants to merge 9 commits into
mainfrom
ci-bigtable-split-admin-data-presubmits
Open

igorbernstein2 wants to merge 9 commits into
mainfrom
ci-bigtable-split-admin-data-presubmits

Conversation

@igorbernstein2

@igorbernstein2 igorbernstein2 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Decouples Bigtable Admin and Data integration test profiles and configures 6 parallel Kokoro presubmit jobs to minimize PR feedback wall-clock time.

Merge Order: Stacked on top of #15058 — merge #15058 first, then #15060, and submit the cloud-devrel Kokoro presubmit CL after #15060 merges.

Changes

  • Split Admin & Data Failsafe Profiles (java-bigtable/google-cloud-bigtable/pom.xml):
    • Adds bigtable-admin-it profile (com.google.cloud.bigtable.admin.v2.it.*IT).
    • Scopes bigtable-prod-it profile to data-plane ITs (com.google.cloud.bigtable.data.v2.it.*IT).
  • 6 Parallel Kokoro Presubmit Configs (.kokoro/presubmit/):
    1. bigtable-integration-admin.cfg: -P bigtable-admin-it (with CMEK properties)
    2. bigtable-integration.cfg: -P bigtable-prod-it,enable-verbose-grpc-logs
    3. bigtable-integration-cfe.cfg: -P bigtable-cfe-it,enable-verbose-grpc-logs
    4. bigtable-integration-dp.cfg: -P bigtable-directpath-it,enable-verbose-grpc-logs
    5. bigtable-integration-session.cfg: -P bigtable-cfe-it,bigtable-session-it,enable-verbose-grpc-logs
    6. bigtable-integration-session-dp.cfg: -P bigtable-directpath-it,bigtable-session-it,enable-verbose-grpc-logs

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new Kokoro presubmit configurations (bigtable-integration-admin.cfg, bigtable-integration-cfe.cfg, and bigtable-integration-session-dp.cfg) to split and run different suites of Bigtable integration tests. It also updates the existing bigtable-integration.cfg to remove CMEK-related properties. In pom.xml, a new Maven profile bigtable-admin-it is added to run admin integration tests, and the bigtable-prod-it profile is updated to target only data integration tests (com.google.cloud.bigtable.data.v2.it.*IT) instead of all integration tests. There are no review comments, and I have no additional feedback to provide.

@igorbernstein2
igorbernstein2 force-pushed the ci-bigtable-split-admin-data-presubmits branch from 556366a to 69ea893 Compare November 18, 2026 16:08
blakeli0 pushed a commit that referenced this pull request Nov 18, 2026
…15058)

Extracts stale resource cleanup out of `TestEnvRule.after()` into a
standalone `StaleResourceCleaner` utility scheduled via a nightly Kokoro
job, eliminating ~60+ redundant Admin API list scans per PR.

> **Merge Order**: Standalone on `main` — merge **before** PR #15060,
`cl/1023908200`, and the `cloud-bigtable` nightly cleanup CL.

### Changes
- **Extract `StaleResourceCleaner`**: Moves stale resource cleanup (>24h
old `temp-*` views, tables, authorized views, app profiles, clusters,
backups, and orphaned test instances) out of `TestEnvRule.after()` into
`StaleResourceCleaner` using `CloudEnv` (`AbstractTestEnv`), with JUnit
5 unit tests in `StaleResourceCleanerTest`.
- **Clean up `TestEnvRule` & `pom.xml`**: Removes `cleanUpStale()` and
unused `grpcLogHandler` / `bigtable.grpc-log-dir` from
`TestEnvRule.java` and `google-cloud-bigtable/pom.xml`, and configures
an `exec-maven-plugin` execution (`exec:java@cleanup-stale-resources`)
to run `StaleResourceCleaner`.
- **Nightly Kokoro Cleanup Config**: Adds
`.kokoro/nightly/bigtable-cleanup.cfg` and `.kokoro/bigtable-cleanup.sh`
to run `StaleResourceCleaner` against `gcloud-devel`
(`google-cloud-bigtable` and `google-cloud-bigtable-session`).
Base automatically changed from ci-bigtable-stale-resource-cleaner to main November 18, 2026 16:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants